[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33363: [SPARK-36156][SQL] SCRIPT TRANSFORM ROW FORMAT DELIMITED should respect `NULL DEFINED AS` and default value should be `\N`

Thu, 15 Jul 2021 19:16:07 -0700 


AngersZhuuuu commented on a change in pull request #33363:
URL: https://github.com/apache/spark/pull/33363#discussion_r670917829



##########
File path: sql/core/src/test/resources/sql-tests/inputs/transform.sql
##########
@@ -121,6 +121,38 @@ USING 'cat' AS (d)
   NULL DEFINED AS 'NULL'
 FROM t;
 
+SELECT TRANSFORM(a, b, c, null)
+  ROW FORMAT DELIMITED
+  FIELDS TERMINATED BY '@'
+  LINES TERMINATED BY '\n'
+USING 'cat' AS (a, b, c, d)
+  ROW FORMAT DELIMITED
+  FIELDS TERMINATED BY '@'
+  LINES TERMINATED BY '\n'
+  NULL DEFINED AS 'NULL'

Review comment:
       > What if `NULL DEFINED` includes a meta character, e.g., `\n`? It works 
well?
   
   No, also in hive
   
![image](https://user-images.githubusercontent.com/46485123/125881169-4cbd510c-0a61-4125-8045-94073764f150.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to