HyukjinKwon commented on a change in pull request #33263:
URL: https://github.com/apache/spark/pull/33263#discussion_r670924438
##########
File path: core/src/main/scala/org/apache/spark/util/logging/FileAppender.scala
##########
@@ -26,8 +26,12 @@ import org.apache.spark.util.{IntParam, Utils}
/**
* Continuously appends the data from an input stream into the given file.
*/
-private[spark] class FileAppender(inputStream: InputStream, file: File,
bufferSize: Int = 8192)
- extends Logging {
+private[spark] class FileAppender(
+ inputStream: InputStream,
+ file: File,
+ bufferSize: Int = 8192,
+ closeStreams: Boolean = false
Review comment:
shall we name it `closeInputStream`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
