HyukjinKwon commented on a change in pull request #33291:
URL: https://github.com/apache/spark/pull/33291#discussion_r670959133
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
##########
@@ -351,10 +351,20 @@ object PartitioningUtils {
*/
def getPathFragment(spec: TablePartitionSpec, partitionSchema: StructType):
String = {
partitionSchema.map { field =>
- escapePathName(field.name) + "=" +
getPartitionValueString(spec(field.name))
+ escapePathName(field.name) + "=" +
+ getPartitionValueString(
+ removeLeadingZerosFromNumberTypePartition(spec(field.name),
field.dataType))
}.mkString("/")
}
+ def removeLeadingZerosFromNumberTypePartition(value: String, dataType:
DataType): String = {
Review comment:
I didn't take a close look but I do think we should deduplicate these
codes. At the very least you can reuse cast expression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
