attilapiros commented on a change in pull request #33340:
URL: https://github.com/apache/spark/pull/33340#discussion_r671049596



##########
File path: 
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RetryingBlockTransferor.java
##########
@@ -34,44 +34,48 @@
 import org.apache.spark.network.util.TransportConf;
 
 /**
- * Wraps another BlockFetcher with the ability to automatically retry fetches 
which fail due to
- * IOExceptions, which we hope are due to transient network conditions.
+ * Wraps another BlockFetcher or BlockPusher with the ability to automatically 
retry fetches or
+ * pushes which fail due to IOExceptions, which we hope are due to transient 
network conditions.
  *
- * This fetcher provides stronger guarantees regarding the parent 
BlockFetchingListener. In
+ * This transferor provides stronger guarantees regarding the parent 
BlockTransferListener. In
  * particular, the listener will be invoked exactly once per blockId, with a 
success or failure.
  */
-public class RetryingBlockFetcher {
+public class RetryingBlockTransferor {

Review comment:
       ..but transfer itself means a different thing.
   
   I searched for synonyms and found this:
   
   ```
   Synonyms: transferor
   
   Definition: (law) someone who conveys a title or property to another
   
   Similar words: transferer, transferrer
   
   Definition: someone who transfers something
   ```
    
    Moreover this:
   
   ```
   A person or thing that carries, holds, or conveys something
   
   carrier bearer transporter conveyor courier haulier porter runner carman 
carter exporter hauler importer messenger mover shipper delivery man delivery 
woman delivery person delivery service letter carrier mail carrier shipping 
agent assistant sender merchant consigner caddie
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to