mridulm commented on a change in pull request #33078:
URL: https://github.com/apache/spark/pull/33078#discussion_r671308507
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java
##########
@@ -742,49 +825,11 @@ AppShufflePartitionInfo getPartitionInfo() {
}
}
- /**
- * ID that uniquely identifies a shuffle for an application. This is used as
a key in
- * {@link #partitions}.
- */
- public static class AppShuffleId {
- public final String appId;
- public final int shuffleId;
-
- AppShuffleId(String appId, int shuffleId) {
- this.appId = appId;
- this.shuffleId = shuffleId;
- }
-
- @Override
- public boolean equals(Object o) {
- if (this == o) {
- return true;
- }
- if (o == null || getClass() != o.getClass()) {
- return false;
- }
- AppShuffleId that = (AppShuffleId) o;
- return shuffleId == that.shuffleId && Objects.equal(appId, that.appId);
- }
-
- @Override
- public int hashCode() {
- return Objects.hashCode(appId, shuffleId);
- }
-
- @Override
- public String toString() {
- return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE)
- .append("appId", appId)
- .append("shuffleId", shuffleId)
- .toString();
- }
- }
-
/** Metadata tracked for an actively merged shuffle partition */
public static class AppShufflePartitionInfo {
- private final AppShuffleId appShuffleId;
+ private final String appId;
+ private final int shuffleId;
private final int reduceId;
// The merged shuffle data file channel
public FileChannel dataChannel;
Review comment:
Given changes, make `dataChannel`, `indexFile` and `metaFile` also
`final` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
