viirya commented on a change in pull request #33401:
URL: https://github.com/apache/spark/pull/33401#discussion_r671643401
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala
##########
@@ -337,69 +337,6 @@ class RocksDBSuite extends SparkFunSuite {
}
}
- ignore("ensure that concurrent update and cleanup consistent versions") {
- quietly {
- val numThreads = 20
- val numUpdatesInEachThread = 20
- val remoteDir = Utils.createTempDir().toString
- @volatile var exception: Exception = null
- val updatingThreads = Array.fill(numThreads) {
- new Thread() {
- override def run(): Unit = {
- try {
- for (version <- 0 to numUpdatesInEachThread) {
- withDB(
- remoteDir,
- version = version) { db =>
- val prevValue =
Option(toStr(db.get("a"))).getOrElse("0").toInt
- db.put("a", (prevValue + 1).toString)
- db.commit()
- }
- }
- } catch {
- case e: Exception =>
- val newException = new Exception(s"ThreadId ${this.getId}
failed", e)
- if (exception != null) {
Review comment:
First all, `exception` is null at beginning. So this condition will be
never satisfied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
