cloud-fan commented on a change in pull request #33396:
URL: https://github.com/apache/spark/pull/33396#discussion_r672012465
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/CustomShuffleReaderRule.scala
##########
@@ -30,4 +30,6 @@ trait CustomShuffleReaderRule extends Rule[SparkPlan] {
* Returns the list of [[ShuffleOrigin]]s supported by this rule.
*/
def supportedShuffleOrigins: Seq[ShuffleOrigin]
+
+ def mayAddExtraShuffles: Boolean = false
Review comment:
That means the `CostEvaluator` should also consider the number of sorts,
not only shuffles. It's doable, but we need more discussion for this new cost
model.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
