HyukjinKwon opened a new pull request #33429:
URL: https://github.com/apache/spark/pull/33429


   ### What changes were proposed in this pull request?
   
   This PR proposes to rename:
   
   - Rename `*Reader`/`*reader` to `*Read`/`*read` for rules and execution plan 
(user-facing doc/config name remain untouched)
     - `*ShuffleReaderExec` ->`*ShuffleReadExec`
     - `isLocalReader` -> `isLocalRead`
     - ...
   - Rename `CustomShuffle*` prefix to `AQEShuffle*`
   - Rename `OptimizeLocalShuffleReader` rule to `OptimizeShuffleWithLocalRead`
   
   ### Why are the changes needed?
   
   There are multiple problems in the current naming:
   
   - `CustomShuffle*` -> `AQEShuffle*`
       it sounds like it is a pluggable API. However, this is actually only 
used by AQE.
   - `OptimizeLocalShuffleReader` -> `OptimizeShuffleWithLocalRead`
       it is the name of a rule but it can be misread as a reader, which is 
counterintuative
   - `*ReaderExec` -> `*ReadExec`
       Reader execution reads a bit odd. It should better be read execution 
(like `ScanExec`, `ProjectExec` and `FilterExec`). I can't find the reason to 
name it with something that performs an action.
   
   ### Does this PR introduce _any_ user-facing change?
   
   ### How was this patch tested?
   
   Existing unittests should cover the changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to