HyukjinKwon commented on a change in pull request #33412:
URL: https://github.com/apache/spark/pull/33412#discussion_r672090113



##########
File path: .github/workflows/build_and_test.yml
##########
@@ -84,13 +84,12 @@ jobs:
         ref: master
     - name: Sync the current branch with the latest in Apache Spark
       if: github.repository != 'apache/spark'
-      id: sync-branch
       run: |
         apache_spark_ref=`git rev-parse HEAD`
         git fetch https://github.com/$GITHUB_REPOSITORY.git 
${GITHUB_REF#refs/heads/}
         git -c user.name='Apache Spark Test Account' -c 
user.email='[email protected]' merge --no-commit --progress --squash 
FETCH_HEAD
         git -c user.name='Apache Spark Test Account' -c 
user.email='[email protected]' commit -m "Merged commit"
-        echo "::set-output name=APACHE_SPARK_REF::$apache_spark_ref"
+        echo "::set-env name=APACHE_SPARK_REF::$apache_spark_ref"

Review comment:
       ```suggestion
   ```

##########
File path: .github/workflows/build_and_test.yml
##########
@@ -182,13 +180,12 @@ jobs:
         ref: master
     - name: Sync the current branch with the latest in Apache Spark
       if: github.repository != 'apache/spark'
-      id: sync-branch
       run: |
         apache_spark_ref=`git rev-parse HEAD`

Review comment:
       ```suggestion
           echo "APACHE_SPARK_REF=$(git rev-parse HEAD)" >> $GITHUB_ENV
   ```

##########
File path: .github/workflows/build_and_test.yml
##########
@@ -632,13 +621,12 @@ jobs:
         ref: master
     - name: Sync the current branch with the latest in Apache Spark
       if: github.repository != 'apache/spark'
-      id: sync-branch
       run: |
         apache_spark_ref=`git rev-parse HEAD`
         git fetch https://github.com/$GITHUB_REPOSITORY.git 
${GITHUB_REF#refs/heads/}
         git -c user.name='Apache Spark Test Account' -c 
user.email='[email protected]' merge --no-commit --progress --squash 
FETCH_HEAD
         git -c user.name='Apache Spark Test Account' -c 
user.email='[email protected]' commit -m "Merged commit"
-        echo "::set-output name=APACHE_SPARK_REF::$apache_spark_ref"
+        echo "::set-env name=APACHE_SPARK_REF::$apache_spark_ref"

Review comment:
       ```suggestion
   ```

##########
File path: .github/workflows/build_and_test.yml
##########
@@ -254,13 +250,12 @@ jobs:
         ref: master
     - name: Sync the current branch with the latest in Apache Spark
       if: github.repository != 'apache/spark'
-      id: sync-branch
       run: |
         apache_spark_ref=`git rev-parse HEAD`

Review comment:
       ```suggestion
           echo "APACHE_SPARK_REF=$(git rev-parse HEAD)" >> $GITHUB_ENV
   ```

##########
File path: .github/workflows/build_and_test.yml
##########
@@ -632,13 +621,12 @@ jobs:
         ref: master
     - name: Sync the current branch with the latest in Apache Spark
       if: github.repository != 'apache/spark'
-      id: sync-branch
       run: |
         apache_spark_ref=`git rev-parse HEAD`

Review comment:
       ```suggestion
           echo "APACHE_SPARK_REF=$(git rev-parse HEAD)" >> $GITHUB_ENV
   ```

##########
File path: .github/workflows/build_and_test.yml
##########
@@ -84,13 +84,12 @@ jobs:
         ref: master
     - name: Sync the current branch with the latest in Apache Spark
       if: github.repository != 'apache/spark'
-      id: sync-branch
       run: |
         apache_spark_ref=`git rev-parse HEAD`

Review comment:
       ```suggestion
           echo "APACHE_SPARK_REF=$(git rev-parse HEAD)" >> $GITHUB_ENV
   ```

##########
File path: .github/workflows/build_and_test.yml
##########
@@ -254,13 +250,12 @@ jobs:
         ref: master
     - name: Sync the current branch with the latest in Apache Spark
       if: github.repository != 'apache/spark'
-      id: sync-branch
       run: |
         apache_spark_ref=`git rev-parse HEAD`
         git fetch https://github.com/$GITHUB_REPOSITORY.git 
${GITHUB_REF#refs/heads/}
         git -c user.name='Apache Spark Test Account' -c 
user.email='[email protected]' merge --no-commit --progress --squash 
FETCH_HEAD
         git -c user.name='Apache Spark Test Account' -c 
user.email='[email protected]' commit -m "Merged commit"
-        echo "::set-output name=APACHE_SPARK_REF::$apache_spark_ref"
+        echo "::set-env name=APACHE_SPARK_REF::$apache_spark_ref"

Review comment:
       ```suggestion
   ```

##########
File path: .github/workflows/build_and_test.yml
##########
@@ -182,13 +180,12 @@ jobs:
         ref: master
     - name: Sync the current branch with the latest in Apache Spark
       if: github.repository != 'apache/spark'
-      id: sync-branch
       run: |
         apache_spark_ref=`git rev-parse HEAD`
         git fetch https://github.com/$GITHUB_REPOSITORY.git 
${GITHUB_REF#refs/heads/}
         git -c user.name='Apache Spark Test Account' -c 
user.email='[email protected]' merge --no-commit --progress --squash 
FETCH_HEAD
         git -c user.name='Apache Spark Test Account' -c 
user.email='[email protected]' commit -m "Merged commit"
-        echo "::set-output name=APACHE_SPARK_REF::$apache_spark_ref"
+        echo "::set-env name=APACHE_SPARK_REF::$apache_spark_ref"

Review comment:
       ```suggestion
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to