viirya commented on a change in pull request #33423:
URL: https://github.com/apache/spark/pull/33423#discussion_r672916226
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
##########
@@ -2040,6 +2040,23 @@ class DatasetSuite extends QueryTest
joined,
(1, 1), (2, 2), (3, 3))
}
+
+ test("SPARK-36210: withColumns preserve insertion ordering") {
+ val df = Seq(1, 2, 3).toDS()
Review comment:
I think `withColumns` doesn't allow duplicate column names.
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
##########
@@ -2040,6 +2040,23 @@ class DatasetSuite extends QueryTest
joined,
(1, 1), (2, 2), (3, 3))
}
+
+ test("SPARK-36210: withColumns preserve insertion ordering") {
+ val df = Seq(1, 2, 3).toDS()
Review comment:
There is one test in `DataFrameSuite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
