dominikgehl commented on a change in pull request #33438:
URL: https://github.com/apache/spark/pull/33438#discussion_r673018987
##########
File path: python/pyspark/ml/util.py
##########
@@ -460,8 +461,8 @@ class DefaultParamsReadable(MLReadable):
If a :py:class:`Params` class stores all data as :py:class:`Param` values,
then extending this trait will provide a default implementation of reading
saved
instances of the class. This only handles simple :py:class:`Param` types;
- e.g., it will not handle :py:class:`Dataset`. See
:py:class:`DefaultParamsWritable`,
- the counterpart to this trait.
+ e.g., it will not handle :py:class:`pyspark.sql.DataFrame`. See
+ :py:class:`DefaultParamsWritable`, the counterpart to this trait.
Review comment:
in this file, :py:class is used everywhere . I don't mind changing the
above, but maybe we should then change it everywhere for consistency ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
