dongjoon-hyun commented on a change in pull request #31905:
URL: https://github.com/apache/spark/pull/31905#discussion_r672378395
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -1947,6 +1947,31 @@ class Dataset[T] private[sql](
CollectMetrics(name, (expr +: exprs).map(_.named), logicalPlan)
}
+ /**
+ * Observe (named) metrics through an [[org.apache.spark.sql.Observation]]
instance.
Review comment:
Yes, another PR would be cleaner. You can put the link of new PR here,
@EnricoMi .
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -1947,6 +1947,31 @@ class Dataset[T] private[sql](
CollectMetrics(name, (expr +: exprs).map(_.named), logicalPlan)
}
+ /**
+ * Observe (named) metrics through an [[org.apache.spark.sql.Observation]]
instance.
Review comment:
Yes, another PR would be cleaner because this PR seems to have a long
history since March.. You can put the link of new PR here, @EnricoMi .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
