HyukjinKwon commented on a change in pull request #31905:
URL: https://github.com/apache/spark/pull/31905#discussion_r672253378
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -1947,6 +1947,31 @@ class Dataset[T] private[sql](
CollectMetrics(name, (expr +: exprs).map(_.named), logicalPlan)
}
+ /**
+ * Observe (named) metrics through an [[org.apache.spark.sql.Observation]]
instance.
Review comment:
I think you can reproduce it via `./build/sbt unidoc`.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -1947,6 +1947,31 @@ class Dataset[T] private[sql](
CollectMetrics(name, (expr +: exprs).map(_.named), logicalPlan)
}
+ /**
+ * Observe (named) metrics through an [[org.apache.spark.sql.Observation]]
instance.
Review comment:
hm, feel free to open a PR and leverage GitHub Actions build
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -1947,6 +1947,31 @@ class Dataset[T] private[sql](
CollectMetrics(name, (expr +: exprs).map(_.named), logicalPlan)
}
+ /**
+ * Observe (named) metrics through an [[org.apache.spark.sql.Observation]]
instance.
Review comment:
oh btw some errors from unidoc are fake. I think the real errors are:
```
[error]
/home/runner/work/spark/spark/sql/core/target/java/org/apache/spark/sql/Dataset.java:1800:1:
error: unexpected text
[error] * This is equivalent to calling {@link Dataset.observe(String,
Column, Column*)} but does
[error] ^
[error]
/home/runner/work/spark/spark/sql/core/target/java/org/apache/spark/sql/Dataset.java:1804:1:
error: reference not found
[error] * A user can retrieve the metrics by accessing {@link
org.apache.spark.sql.Observation.get}.
[error] ^
[error]
/home/runner/work/spark/spark/sql/core/target/java/org/apache/spark/sql/Observation.java:51:1:
error: exception not thrown: java.lang.InterruptedException
[error] * @throws java.lang.InterruptedException interrupted while waiting
[error] ^
```
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -1947,6 +1947,31 @@ class Dataset[T] private[sql](
CollectMetrics(name, (expr +: exprs).map(_.named), logicalPlan)
}
+ /**
+ * Observe (named) metrics through an [[org.apache.spark.sql.Observation]]
instance.
Review comment:
you might have to just wrap these three instances with backtics instead
of `[[..]]` as a workaround.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
