HyukjinKwon commented on a change in pull request #33431:
URL: https://github.com/apache/spark/pull/33431#discussion_r673102615
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/CustomShuffleReaderExec.scala
##########
@@ -34,11 +34,14 @@ import org.apache.spark.sql.vectorized.ColumnarBatch
*
* @param child It is usually `ShuffleQueryStageExec`, but can be
the shuffle exchange
* node during canonicalization.
- * @param partitionSpecs The partition specs that defines the arrangement.
+ * @param partitionSpecs The partition specs that defines the arrangement,
requires at least one
+ * partition.
*/
case class CustomShuffleReaderExec private(
child: SparkPlan,
partitionSpecs: Seq[ShufflePartitionSpec]) extends UnaryExecNode {
+ assert(partitionSpecs.nonEmpty, "CustomShuffleReaderExec requires at least
one partition")
Review comment:
nit but let's use getClass or something next time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
