srowen commented on a change in pull request #33440:
URL: https://github.com/apache/spark/pull/33440#discussion_r673103150
##########
File path: python/pyspark/sql/session.py
##########
@@ -73,7 +73,7 @@ class SparkSession(SparkConversionMixin):
A SparkSession can be used create :class:`DataFrame`, register
:class:`DataFrame` as
tables, execute SQL over tables, cache tables, and read parquet files.
- To create a SparkSession, use the following builder pattern:
+ To create a :class:`SparkSession`, use the following builder pattern:
Review comment:
This is fine, but do we do it consistently? if that would be a big
change, I wonder how much it's worth it
##########
File path: python/pyspark/sql/group.py
##########
@@ -238,7 +238,7 @@ def pivot(self, pivot_col, values=None):
----------
pivot_col : str
Name of the column to pivot.
- values :
+ values : list, optional
Review comment:
Do we use this convention anywhere else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
