GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/5903
[SPARK-5074][Core][Tests] Fix the flakey test 'run shuffle with map stage
failure' in DAGSchedulerSuite
Test failure:
https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-SBT/AMPLAB_JENKINS_BUILD_PROFILE=hadoop2.2,label=centos/2240/testReport/junit/org.apache.spark.scheduler/DAGSchedulerSuite/run_shuffle_with_map_stage_failure/
This is because all tests share the same `JobListener`. Because after each
test, `scheduler` isn't stopped. So actually it's still running. When running
the test `run shuffle with map stage failure`, some previous test may trigger
[ResubmitFailedStages](https://github.com/apache/spark/blob/ebc25a4ddfe07a67668217cec59893bc3b8cf730/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L1120)
logic, and report `jobFailed` and override the global `failure` variable.
This PR uses `after` to call `scheduler.stop()` for each test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark SPARK-5074
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5903.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5903
----
commit 1e6f13e0d75f1bfaeaa6a0203e55c1a492778019
Author: zsxwing <[email protected]>
Date: 2015-05-05T04:48:07Z
Fix the flakey test 'run shuffle with map stage failure' in
DAGSchedulerSuite
Test failure:
https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-SBT/AMPLAB_JENKINS_BUILD_PROFILE=hadoop2.2,label=centos/2240/testReport/junit/org.apache.spark.scheduler/DAGSchedulerSuite/run_shuffle_with_map_stage_failure/
This is because all tests share the same `JobListener`. Because after each
test, `scheduler` isn't stopped. So actually it's still running. When running
the test `run shuffle with map stage failure`, some previous test may trigger
`ResubmitFailedStages` logic and override the global `failure` variable.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
