HyukjinKwon commented on a change in pull request #33437:
URL: https://github.com/apache/spark/pull/33437#discussion_r673644969



##########
File path: python/pyspark/sql/types.py
##########
@@ -107,7 +107,8 @@ class NullType(DataType, metaclass=DataTypeSingleton):
 
     The data type representing None, used for the types that cannot be 
inferred.
     """
-    pass
+    def simpleString(self):

Review comment:
       the json format there is internal purpose. It's not supposed to be 
stored outside so it should be fine. I am asking this because usage with 
`typeName` is documented, for exmaple, here:
   
   
https://github.com/apache/spark/blob/2537fe8cbaf49070137d4b5bc39af078b306c4c8/python/pyspark/sql/session.py#L51-L52
   
   If we're worried about anything related to it, we could rather update the 
docs instead for now. I am fine with this too.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to