Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/5860#discussion_r29646250
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -179,6 +179,11 @@ private[spark] object ClosureCleaner extends Logging {
cleanTransitively: Boolean,
accessedFields: Map[Class[_], Set[String]]): Unit = {
+ if (!isClosure(func.getClass)) {
+ logWarning("Expected a closure; got " + func.getClass.getName)
--- End diff --
Any reason not to make this an assertion? Isn't it simply invalid if we
call this on something that is not a closure?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
