cloud-fan commented on a change in pull request #33352:
URL: https://github.com/apache/spark/pull/33352#discussion_r673998484
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala
##########
@@ -83,16 +205,37 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan] {
} else {
withFilter
}
-
withProjection
}
+
+ private def getWrappedScan(
+ scan: Scan,
+ sHolder: ScanBuilderHolder,
+ aggregation: Option[Aggregation]): Scan = {
+ scan match {
+ case v1: V1Scan =>
+ val pushedFilters = sHolder.builder match {
+ case f: SupportsPushDownFilters =>
+ f.pushedFilters()
+ case _ => Array.empty[sources.Filter]
+ }
+ V1ScanWrapper(v1, Array.empty[sources.Filter], pushedFilters,
aggregation)
Review comment:
It seems like only for display purposes. I'm OK to remove it but let's
do it more explicitly and remove this field from `V1ScanWrapper`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
