cloud-fan commented on a change in pull request #33459:
URL: https://github.com/apache/spark/pull/33459#discussion_r674146391
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala
##########
@@ -89,6 +91,10 @@ object NumberConverter {
var i = fromPos
while (i < value.length) {
value(i) = Character.digit(value(i), radix).asInstanceOf[Byte]
+ // if invalid characters are found, it no need to convert the suffix
starting there
Review comment:
can we update the method doc as well? it currently says `Convert invalid
characters to -1.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
