huaxingao commented on a change in pull request #33352:
URL: https://github.com/apache/spark/pull/33352#discussion_r674407692
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
##########
@@ -152,19 +179,27 @@ object JDBCRDD extends Logging {
requiredColumns: Array[String],
filters: Array[Filter],
parts: Array[Partition],
- options: JDBCOptions): RDD[InternalRow] = {
+ options: JDBCOptions,
+ outputSchema: Option[StructType] = None,
+ groupByColumns: Option[Array[FieldReference]] = None): RDD[InternalRow]
= {
Review comment:
I guess no. I am using this `groupByColumns` to tell if aggregate is
pushed down. Having this as an Option, I can do this:
```
if (groupByColumns.isEmpty) { // no pushed down aggregate
quote columns
} else {
// columns already quoated
if (groupByColumns.get.isEmpty) { // no group by columns
getGroupByClause = ""
} else {
getGroupByClause = ...
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
