[GitHub] [spark] itholic commented on a change in pull request #33450: [SPARK-35809][PYTHON] Add `index_col` argument for ps.sql

Wed, 21 Jul 2021 18:07:23 -0700 


itholic commented on a change in pull request #33450:
URL: https://github.com/apache/spark/pull/33450#discussion_r674439235



##########
File path: python/pyspark/pandas/sql_processor.py
##########
@@ -65,6 +66,9 @@ def sql(
     ----------
     query : str
         the SQL query
+    index_col : str or list of str, optional

Review comment:
       Seems like they have an example in their official 
[documents](https://numpydoc.readthedocs.io/en/latest/format.html)?
   
   ![Screen Shot 2021-07-22 at 10 03 27 
AM](https://user-images.githubusercontent.com/44108233/126577733-7c6d0aec-ba40-4f00-8346-a7647a033cdf.png)
   
   See the `files` example.
   
   And pandas also has some cases using `list of str` such as 
https://github.com/pandas-dev/pandas/blob/0eceea496746769e4781f081b8c7159b1ce9f8f0/pandas/core/accessor.py#L70
 or 
https://github.com/pandas-dev/pandas/blob/059c8bac51e47d6eaaa3e36d6a293a22312925e6/pandas/tests/reshape/merge/test_merge_index_as_string.py#L71-L76.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to