xinrong-databricks commented on a change in pull request #33470:
URL: https://github.com/apache/spark/pull/33470#discussion_r674460513
##########
File path: python/pyspark/pandas/categorical.py
##########
@@ -165,8 +165,84 @@ def codes(self) -> "ps.Series":
),
).rename()
- def add_categories(self, new_categories: pd.Index, inplace: bool = False)
-> "ps.Series":
- raise NotImplementedError()
+ def add_categories(
+ self, new_categories: Union[pd.Index, Any, List], inplace: bool = False
+ ) -> Optional["ps.Series"]:
+ """
+ Add new categories.
+
+ `new_categories` will be included at the last/highest place in the
+ categories and will be unused directly after this call.
+
+ Parameters
+ ----------
+ new_categories : category or list-like of category
+ The new categories to be included.
+ inplace : bool, default False
+ Whether or not to add the categories inplace or return a copy of
+ this categorical with added categories.
+
+ Returns
+ -------
+ Series or None
+ Categorical with new categories added or None if ``inplace=True``.
+
+ Raises
+ ------
+ ValueError
+ If the new categories include old categories or do not validate as
+ categories
+
+ Examples
+ --------
+ >>> s = ps.Series(list("abbccc"), dtype="category")
+ >>> s # doctest: +SKIP
Review comment:
Why is it skipped?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
