Ngone51 commented on a change in pull request #33116:
URL: https://github.com/apache/spark/pull/33116#discussion_r674484740
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockHandler.java
##########
@@ -299,13 +301,17 @@ private void checkAuth(TransportClient client, String
appId) {
public class ShuffleMetrics implements MetricSet {
private final Map<String, Metric> allMetrics;
// Time latency for open block request in ms
- private final Timer openBlockRequestLatencyMillis = new Timer();
+ private final Timer openBlockRequestLatencyMillis =
+ new TimerWithCustomTimeUnit(TimeUnit.MILLISECONDS);
// Time latency for executor registration latency in ms
- private final Timer registerExecutorRequestLatencyMillis = new Timer();
+ private final Timer registerExecutorRequestLatencyMillis =
+ new TimerWithCustomTimeUnit(TimeUnit.MILLISECONDS);
// Time latency for processing fetch merged blocks meta request latency in
ms
- private final Timer fetchMergedBlocksMetaLatencyMillis = new Timer();
+ private final Timer fetchMergedBlocksMetaLatencyMillis =
+ new TimerWithCustomTimeUnit(TimeUnit.MILLISECONDS);
Review comment:
cc @Victsm @otterc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
