LuciferYang commented on pull request #33460: URL: https://github.com/apache/spark/pull/33460#issuecomment-884642011
> I would prefer if we had a test for this btw @LuciferYang. How can I create a successful `flush` but fail to `writer.close()` case when calling this method? `writer` is a local variable in `ExternalSorter#spillMemoryIteratorToDisk` method and `spillMemoryIteratorToDisk` is `private` method, so it's hard to mock writer`'s behavior. Do you have any suggestions for this? @mridulm @HyukjinKwon @Ngone51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
