MaxGekk commented on a change in pull request #33456:
URL: https://github.com/apache/spark/pull/33456#discussion_r674505943
##########
File path:
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/DateTimeConstants.java
##########
@@ -21,6 +21,8 @@
public static final int MONTHS_PER_YEAR = 12;
+ public static final byte DAYS_PER_MONTH = 31;
Review comment:
Let's **not** add this here. 31 days per month is streaming specific
constant. And it is not applicable to other classes in Spark SQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
