cloud-fan commented on a change in pull request #33468:
URL: https://github.com/apache/spark/pull/33468#discussion_r674561736
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -3300,6 +3300,41 @@ class Analyzer(override val catalogManager:
CatalogManager)
} else {
v2Write
}
+
+ case u: UpdateTable if !u.skipSchemaResolution && u.resolved =>
+ resolveAssignments(u)
+
+ case m: MergeIntoTable if !m.skipSchemaResolution && m.resolved =>
+ resolveAssignments(m)
+ }
+
+ private def resolveAssignments(p: LogicalPlan): LogicalPlan = {
+ p.transformExpressions {
+ case assignment: Assignment =>
+ val nullHandled = if (!assignment.key.nullable &&
assignment.value.nullable) {
+ AssertNotNull(assignment.value)
+ } else {
+ assignment.value
+ }
+ val casted = if (assignment.key.dataType != nullHandled.dataType) {
+ AnsiCast(nullHandled, assignment.key.dataType)
Review comment:
Seems it's a new code path, I didn't take care of the legacy mode and
use ansi behavior directly.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -3300,6 +3300,41 @@ class Analyzer(override val catalogManager:
CatalogManager)
} else {
v2Write
}
+
+ case u: UpdateTable if !u.skipSchemaResolution && u.resolved =>
+ resolveAssignments(u)
+
+ case m: MergeIntoTable if !m.skipSchemaResolution && m.resolved =>
+ resolveAssignments(m)
+ }
+
+ private def resolveAssignments(p: LogicalPlan): LogicalPlan = {
+ p.transformExpressions {
+ case assignment: Assignment =>
+ val nullHandled = if (!assignment.key.nullable &&
assignment.value.nullable) {
+ AssertNotNull(assignment.value)
+ } else {
+ assignment.value
+ }
+ val casted = if (assignment.key.dataType != nullHandled.dataType) {
+ AnsiCast(nullHandled, assignment.key.dataType)
Review comment:
since it's a new code path, I didn't take care of the legacy mode and
use ansi behavior directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
