Kimahriman commented on a change in pull request #32987:
URL: https://github.com/apache/spark/pull/32987#discussion_r674791837
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SubexpressionEliminationSuite.scala
##########
@@ -231,13 +233,15 @@ class SubexpressionEliminationSuite extends SparkFunSuite
with ExpressionEvalHel
GreaterThan(add2, Literal(4)) ::
GreaterThan(add2, Literal(5)) :: Nil
- val coalesceExpr1 = Coalesce(conditions1)
- val equivalence1 = new EquivalentExpressions
- equivalence1.addExprTree(coalesceExpr1)
+ withSQLConf(SQLConf.SUBEXPRESSION_ELIMINATION_CONDITIONALS_ENABLED.key ->
"true") {
Review comment:
Same as the CaseWhen above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
