tgravescs commented on a change in pull request #33385:
URL: https://github.com/apache/spark/pull/33385#discussion_r674813459
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -429,6 +429,7 @@ private[spark] class TaskSetManager(
execId: String,
host: String,
maxLocality: TaskLocality.TaskLocality,
+ taskCpuAssignments: Int = 1,
Review comment:
yes if we are going to default to something sched.CPUS_PER_TASK would be
good, but do we even need it defaulting to something versus just make sure its
passed in. That way we know we didn't miss updating it somewhere. If there is
some backwards compatibility concern here then it makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
