Ngone51 commented on a change in pull request #33034:
URL: https://github.com/apache/spark/pull/33034#discussion_r674926155
##########
File path: core/src/main/scala/org/apache/spark/Dependency.scala
##########
@@ -122,6 +119,18 @@ class ShuffleDependency[K: ClassTag, V: ClassTag, C:
ClassTag](
*/
private[this] var _shuffleMergedFinalized: Boolean = false
+ /**
+ * shuffleSequenceId is used to give temporal ordering to the executions of
a ShuffleDependency.
+ * This is required in order to handle indeterministic stage retries for
push-based shuffle.
+ */
+ private[this] var _shuffleSequenceId: Int = -1
Review comment:
How about renaming it as `_shuffleMergeSequenceId ` or just `_
shuffleMergeId `? Because I'm thinking that `_shuffleSequenceId` won't increase
for a determinate stage. But `_shuffleSequenceId` just sounds like it'd
increase whenever the ShuffleDependency is re-executed, even if it's a
determinate stage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
