venkata91 commented on a change in pull request #33034:
URL: https://github.com/apache/spark/pull/33034#discussion_r675050350



##########
File path: 
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java
##########
@@ -353,18 +438,21 @@ public StreamCallbackWithID 
receiveBlockDataAsStream(PushBlockStream msg) {
     // getting killed. When this happens, we need to distinguish the duplicate 
blocks as they
     // arrive. More details on this is explained in later comments.
 
+    // Track if the block is received from an older shuffleSequenceId attempt.
+    final boolean isInvalidBlock = partitionInfoBeforeCheck == 
INVALID_SHUFFLE_PARTITIONS;

Review comment:
       `partitionInfo` will be null not `partitionInfoBeforeCheck`, based on 
`partitionInfoBeforeCheck` we are setting `partitionInfo.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to