otterc commented on a change in pull request #33477:
URL: https://github.com/apache/spark/pull/33477#discussion_r674976476
##########
File path: core/src/main/scala/org/apache/spark/shuffle/ShuffleBlockPusher.scala
##########
@@ -100,7 +106,15 @@ private[spark] class ShuffleBlockPusher(conf: SparkConf)
extends Logging {
pushRequests ++= Utils.randomize(requests)
submitTask(() => {
- pushUpToMax()
+ try {
+ pushUpToMax()
+ } catch {
+ case e: FileNotFoundException =>
Review comment:
Good point! Sure, I will catch it there as well because there is a
chance that `pushUpToMax()` there can throw FNF. We mostly saw the `result`
from push with FNF as failure so `updateStateAndCheckIfPushMore(...)` would
return false. But it might just happen, that the files got deleted after that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
