mridulm commented on a change in pull request #33034:
URL: https://github.com/apache/spark/pull/33034#discussion_r676106194
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java
##########
@@ -725,15 +838,26 @@ public void onData(String streamId, ByteBuffer buf)
throws IOException {
@Override
public void onComplete(String streamId) throws IOException {
synchronized (partitionInfo) {
- logger.trace("{} shuffleId {} reduceId {} onComplete invoked",
- partitionInfo.appId, partitionInfo.shuffleId,
+ logger.trace("{} shuffleId {} shuffleMergeId {} reduceId {} onComplete
invoked",
+ partitionInfo.appId, partitionInfo.shuffleId,
partitionInfo.shuffleMergeId,
partitionInfo.reduceId);
Map<Integer, AppShufflePartitionInfo> shufflePartitions =
- appShuffleInfo.partitions.get(partitionInfo.shuffleId);
+ appShuffleInfo.partitions.get(partitionInfo.shuffleId)
+ .get(partitionInfo.shuffleMergeId);
Review comment:
Handle `null`'s
Essentially, any get on `appShuffleInfo.partitions` can return `null`.
Similarly, a `get` on the returned map can also be `null` - please handle it.
Also, +CC @otterc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
