Victsm commented on a change in pull request #33340:
URL: https://github.com/apache/spark/pull/33340#discussion_r676343560
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/BlockFetchingListener.java
##########
@@ -17,11 +17,11 @@
package org.apache.spark.network.shuffle;
-import java.util.EventListener;
-
import org.apache.spark.network.buffer.ManagedBuffer;
-public interface BlockFetchingListener extends EventListener {
+public interface BlockFetchingListener extends BlockTransferListener {
+ String transferType = "fetch";
Review comment:
Intention was to reuse the same string in a straightforward way when
`RetryingBlockTransferor` repeatedly invokes `getTransferType()` for each block
on multiple push/fetch listeners during block transfer failure/retries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]