darcy-shen commented on a change in pull request #32332:
URL: https://github.com/apache/spark/pull/32332#discussion_r676400183
##########
File path: python/pyspark/sql/session.py
##########
@@ -695,9 +704,10 @@ def prepare(obj):
prepare = lambda obj: obj
Review comment:
> Seems like it does twice when the schema is specified.
When the schema is specified, `_inferSchema` and `_create_verified_converter
` will not be invoked
https://github.com/apache/spark/blob/c561ee686551690bee689f37ae5bbd75119994d6/python/pyspark/sql/session.py#L490-493
##########
File path: python/pyspark/sql/session.py
##########
@@ -695,9 +704,10 @@ def prepare(obj):
prepare = lambda obj: obj
Review comment:
> Seems like it does twice when the schema is specified.
When the schema is specified, `_inferSchema` and `_create_verified_converter
` will not be invoked
https://github.com/apache/spark/blob/c561ee686551690bee689f37ae5bbd75119994d6/python/pyspark/sql/session.py#L490:493
##########
File path: python/pyspark/sql/session.py
##########
@@ -695,9 +704,10 @@ def prepare(obj):
prepare = lambda obj: obj
Review comment:
> Seems like it does twice when the schema is specified.
When the schema is specified, `_inferSchema` and `_create_verified_converter
` will not be invoked
https://github.com/apache/spark/blob/c561ee686551690bee689f37ae5bbd75119994d6/python/pyspark/sql/session.py#L490:L493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
