dgd-contributor commented on a change in pull request #33459:
URL: https://github.com/apache/spark/pull/33459#discussion_r676686936
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala
##########
@@ -49,12 +49,14 @@ object NumberConverter {
*/
private def encode(radix: Int, fromPos: Int, value: Array[Byte]): Long = {
var v: Long = 0L
- val bound = java.lang.Long.divideUnsigned(-1 - radix, radix) // Possible
overflow once
+ // bound will always positive since radix >= 2
+ val bound = java.lang.Long.divideUnsigned(-1 - radix, radix)
Review comment:
bound is the max value which can multiply by radix and plus a value <
radix without overflow when we treat Long value as Unsigned Long value, so if v
is greater than bound, v*radix + value(i) will cause overflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
