Ngone51 commented on a change in pull request #33034:
URL: https://github.com/apache/spark/pull/33034#discussion_r677149702
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java
##########
@@ -648,14 +809,24 @@ public void onData(String streamId, ByteBuffer buf)
throws IOException {
// to disk as well. This way, we avoid having to buffer the entirety of
every blocks in
// memory, while still providing the necessary guarantee.
synchronized (partitionInfo) {
- Map<Integer, AppShufflePartitionInfo> shufflePartitions =
+ Map<Integer, Map<Integer, AppShufflePartitionInfo>>
shuffleMergePartitions =
Review comment:
BTW, it's better to rename this level map to
`shuffleMergePartitionsByMergeId`. `shuffleMergePartitions` is better for the
next level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
