venkata91 commented on a change in pull request #33034:
URL: https://github.com/apache/spark/pull/33034#discussion_r677155722
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/OneForOneBlockPusher.java
##########
@@ -135,13 +135,14 @@ public void start() {
assert buffers.containsKey(blockIds[i]) : "Could not find the block
buffer for block "
+ blockIds[i];
String[] blockIdParts = blockIds[i].split("_");
- if (blockIdParts.length != 4 ||
!blockIdParts[0].equals(SHUFFLE_PUSH_BLOCK_PREFIX)) {
+ if (blockIdParts.length != 5 ||
!blockIdParts[0].equals(SHUFFLE_PUSH_BLOCK_PREFIX)) {
Review comment:
I didn't quite get it. This is in the `push` side right? Can you please
explain a bit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
