cloud-fan commented on a change in pull request #33526:
URL: https://github.com/apache/spark/pull/33526#discussion_r677326804
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Aggregation.java
##########
@@ -28,17 +28,15 @@
*/
@Evolving
public final class Aggregation implements Serializable {
- private AggregateFunc[] aggregateExpressions;
- private FieldReference[] groupByColumns;
+ private final AggregateFunc[] aggregateExpressions;
+ private final FieldReference[] groupByColumns;
public Aggregation(AggregateFunc[] aggregateExpressions, FieldReference[]
groupByColumns) {
this.aggregateExpressions = aggregateExpressions;
this.groupByColumns = groupByColumns;
}
- public AggregateFunc[] aggregateExpressions() {
- return aggregateExpressions;
- }
+ public AggregateFunc[] aggregateExpressions() { return aggregateExpressions;
}
Review comment:
shall we change the code style of `groupByColumns` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
