xkrogen commented on a change in pull request #33308:
URL: https://github.com/apache/spark/pull/33308#discussion_r677642548
##########
File path:
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSerdeSuite.scala
##########
@@ -86,18 +86,18 @@ class AvroSerdeSuite extends SparkFunSuite {
// deserialize should have no issues when 'bar' is nullable but fail when
it is nonnull
Deserializer.create(CATALYST_STRUCT, avro, BY_NAME)
assertFailedConversionMessage(avro, Deserializer, BY_NAME,
- "Cannot find non-nullable field 'foo.bar' (at position 0) in Avro
schema.",
+ "Cannot find field 'foo.bar' in Avro schema",
Review comment:
Since by-name is the default, I'm thinking to omit that, and only
mention if it's using positional matching. WDYT?
##########
File path:
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSerdeSuite.scala
##########
@@ -86,18 +86,18 @@ class AvroSerdeSuite extends SparkFunSuite {
// deserialize should have no issues when 'bar' is nullable but fail when
it is nonnull
Deserializer.create(CATALYST_STRUCT, avro, BY_NAME)
assertFailedConversionMessage(avro, Deserializer, BY_NAME,
- "Cannot find non-nullable field 'foo.bar' (at position 0) in Avro
schema.",
+ "Cannot find field 'foo.bar' in Avro schema",
nonnullCatalyst)
assertFailedConversionMessage(avro, Deserializer, BY_POSITION,
- "Cannot find non-nullable field at position 1 (field 'foo.baz') in Avro
schema.",
+ "Cannot find field at position 1 of field 'foo' from Avro schema",
Review comment:
good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
