dongjoon-hyun commented on a change in pull request #33509: URL: https://github.com/apache/spark/pull/33509#discussion_r677737726
########## File path: sql/core/src/test/scala/org/apache/spark/sql/RewritePredicateSubqueryEndToEndSuite.scala ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql + +import org.apache.spark.sql.execution.adaptive.AdaptiveSparkPlanHelper +import org.apache.spark.sql.execution.exchange.ShuffleExchangeExec +import org.apache.spark.sql.test.SharedSparkSession + +class RewritePredicateSubqueryEndToEndSuite extends QueryTest with SharedSparkSession + with AdaptiveSparkPlanHelper { + + test("SPARK-36280: Remove redundant aliases after RewritePredicateSubquery") { + sql("CREATE TABLE t1 USING parquet AS SELECT id AS a, id AS b, id AS c FROM range(10)") + sql("CREATE TABLE t2 USING parquet AS SELECT id AS x, id AS y FROM range(8)") + val df = sql( + """ + |SELECT * + |FROM t1 + |WHERE a IN (SELECT x + | FROM (SELECT x AS x, + | Rank() OVER (partition BY x ORDER BY Sum(y) DESC) AS ranking + | FROM t2 + | GROUP BY x) tmp1 + | WHERE ranking <= 5) Review comment: Could you adjust the indentation of this query? The horizontal alignment looks having no rule for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
