sunchao commented on a change in pull request #33526:
URL: https://github.com/apache/spark/pull/33526#discussion_r677824345
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/SupportsPushDownAggregates.java
##########
@@ -51,6 +49,8 @@
* Pushes down Aggregation to datasource. The order of the datasource scan
output columns should
* be: grouping columns, aggregate columns (in the same order as the
aggregate functions in
* the given Aggregation).
+ *
+ * Returns true if the aggregation can be pushed down to datasource.
Review comment:
nit: maybe "@return true if the aggregation can be pushed down to
datasource. False otherwise."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
