EnricoMi commented on pull request #33545:
URL: https://github.com/apache/spark/pull/33545#issuecomment-888082838


   @HyukjinKwon `get` now returns the Scala Map, `getAsRow` is removed. I would 
still like to keep `getAsJavaMap` as it simplifies usage in Java (see 
JavaDatasetSuite.java`.
   
   There is one issue with returning a `Map` though: The map will lose some 
metrics when the aggregation expressions have  duplicate column names:
   
       > df.observe(observation, lit(1).as("a"), lit(2).as("a")).count
       > observation.get
       Map(a -> 2)
   
   Should I add some prefix to the duplicate column names?
   
       Map(a_1 -> 1, a_2 -> 2)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to