cloud-fan commented on a change in pull request #33459:
URL: https://github.com/apache/spark/pull/33459#discussion_r678064856
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberConverter.scala
##########
@@ -49,11 +49,22 @@ object NumberConverter {
*/
private def encode(radix: Int, fromPos: Int, value: Array[Byte]): Long = {
var v: Long = 0L
- val bound = java.lang.Long.divideUnsigned(-1 - radix, radix) // Possible
overflow once
+ // bound will always positive since radix >= 2
+ val bound = java.lang.Long.divideUnsigned(-1 - radix, radix)
var i = fromPos
while (i < value.length && value(i) >= 0) {
+ // if v < 0, which mean its bit presentation is start with 1, so v *
radix will cause
+ // overflow since radix is greater than 2
+ if (v < 0) {
+ return -1
+ }
+ // check if v greater than bound
+ // if v is greater than bound, v * radix + radix will cause overflow.
Review comment:
```suggestion
// if v is greater than bound, v * radix + radix may cause overflow.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
