cloud-fan commented on a change in pull request #33451:
URL: https://github.com/apache/spark/pull/33451#discussion_r678377180
##########
File path:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##########
@@ -1203,8 +1297,13 @@ private class BufferReleasingInputStream(
block
} catch {
case e: IOException if detectCorruption =>
+ val diagnosisResponse = checkedInOpt.map { checkedIn =>
+ iterator.diagnoseCorruption(checkedIn, address, blockId)
+ }.orNull
Review comment:
why we call `.orNull` here then pass `Some(diagnosisResponse)`? Shall we
just keep `diagnosisResponse` here as an `Option`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
