mridulm edited a comment on pull request #33555: URL: https://github.com/apache/spark/pull/33555#issuecomment-888457574
I have not followed on this work, but looking at this pr a general comment, please use as specific a subclass as possible without loosing generalizability while defining interfaces. For example, use `Exception` instead of `Throwable` - or relevant subclass if relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
