holdenk commented on a change in pull request #33508:
URL: https://github.com/apache/spark/pull/33508#discussion_r678543219
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
##########
@@ -260,16 +267,22 @@ private[spark] class BasicExecutorFeatureStep(
.withUid(pod.getMetadata.getUid)
.build()
}
+
+ val policy = kubernetesConf.get(KUBERNETES_ALLOCATION_PODSALLOCATOR) match
{
+ case "statefulset" => "Always"
Review comment:
I was doing more thinking about this and I think #2 (ignore existing and
overwrite) is probably the most reasonable, but #1 could also be ok if we
changed the behaviour of the DiskStore to do temporary file writes w/atomic
renames on write completion.
Personally I'm in favour of going for #2 (ignore existing and overwrite) and
leaving the temp file write w/atomic rename as a future improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
