HyukjinKwon commented on a change in pull request #33201:
URL: https://github.com/apache/spark/pull/33201#discussion_r678899424
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -54,38 +54,38 @@ object Cast {
case (NullType, _) => true
- case (_, StringType) => true
+ case (_, StringType | CharType(_) | VarcharType(_)) => true
Review comment:
hey sorry but I can't follow why we should fix this here. char and
varchars are not supposed to be directly used in these expressions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
