linhongliu-db commented on a change in pull request #33510:
URL: https://github.com/apache/spark/pull/33510#discussion_r678930318
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/TPCDSQueryTestSuite.scala
##########
@@ -149,7 +187,12 @@ class TPCDSQueryTestSuite extends QueryTest with TPCDSBase
with SQLQueryTestHelp
classLoader = Thread.currentThread().getContextClassLoader)
test(s"$name-v2.7") {
val goldenFile = new File(s"$baseResourcePath/v2_7", s"$name.sql.out")
- runQuery(queryString, goldenFile)
+ val (schema, output) = runQuery(queryString, goldenFile)
+ if (!regenerateGoldenFiles) {
+ shuffleConfSet.foreach { testConf =>
+ runQueryWithShuffleConf(queryString, schema, output, testConf)
+ }
+ }
Review comment:
I prefer we do this:
1. change the `runQuery(query: String, goldenFile: File)` to
`runQuery(query: String, goldenFile: File, conf: Map[String, String])`
2. if (regenerateGoldenFiles) { runQuery } else { runQuery * 4 } // default
conf + 3 shuffle conf
3. if runQuery under default conf, no need to sort
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
