jerqi commented on a change in pull request #33510:
URL: https://github.com/apache/spark/pull/33510#discussion_r679199883



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/TPCDSQueryTestSuite.scala
##########
@@ -149,7 +187,12 @@ class TPCDSQueryTestSuite extends QueryTest with TPCDSBase 
with SQLQueryTestHelp
         classLoader = Thread.currentThread().getContextClassLoader)
       test(s"$name-v2.7") {
         val goldenFile = new File(s"$baseResourcePath/v2_7", s"$name.sql.out")
-        runQuery(queryString, goldenFile)
+        val (schema, output) = runQuery(queryString, goldenFile)
+        if (!regenerateGoldenFiles) {
+          shuffleConfSet.foreach { testConf =>
+            runQueryWithShuffleConf(queryString, schema, output, testConf)

Review comment:
       The data that read from the output file is a single string. And I can't 
convert the string to a sequence of records with a property Delimiter




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to